About the author

Steven HarmanSteven Harman is a passionate developer who believes that writing great software isn't just a job, its a craft.

ASP.NET MVP

For recent posts and more about me, scroll to the bottom.

Subscribe

  • Subscribe to my feed. via RSS
  • Subscribe via email via email

Jobs

Badges

  • Subtext Project
  • Support Subtext
  • HiddenNetwork.com Banner

Subtext Origami Skin - Hotfix!

Not too long ago a user sent us an email informing us that Subtext’s Origami skin didn’t have a #feedback tag, meaning it was missing a named anchor that would allow you to jump directly to the feedback portion of the page. I took a look and sure enough it didn’t.

This kind of bug is typically referred to as low hanging fruit - easy to spot, quick and easy to fix. So naturally I went ahead and added the named anchor tag, checked it into the Subtext SVN repository and called it fixed.

But it’s not fixed.

Comment Title running into Gravatar image. Today I was reading through some comments on my Life blog and noticed that the Gravatar image and comment title for the first comment of an individual post was not aligned correctly. A little inspection with Firebug and I found the issue.

Mea Culpa!

Apparently even low hanging fruit is sometimes too difficult for me to handle correctly. When I added the anchor tag I incorrectly made it a self-closing tag... which Firefox then misinterpreted and the mess pictured above resulted.

<div id="comments" class="section">
    <a name="feedback" />
    <h2 class="section-title">Your Comments.</h2>

Lucky for me the fix was a simple one. Where have I heard that before?

Like I was saying, the fix was pretty easy - I opened the skin’s Comments.ascx control and changed the anchor tag like so (notice the changes in bold):

<div id="comments" class="section">
    <a name="feedback"></a>
    <h2 class="section-title">Your Comments.</h2>

It’s magic, you know.

That looks better!And just like that all is once again right with the World Subtext’s Origami skin. To all of the Subtexters out there, I would like to apologize for leading you astray... I’ll try my best to make sure it doesn’t happen again. Hopefully this blog post will get me back in your good graces. :)

Oh, and I should mention that this updated fix has been checked into SVN and will be in the forthcoming Subtext 1.9.6 release.

Again, Mea Culpa!

Technorati Tags: ,

What others are saying.

# re: Subtext Origami Skin - Hotfix!
Gravatar Damien Guard
Aug 22, 2007
Another bug in the Origami skin is that the articles are supposed to alternate between green and orange headings but only do so if you post two articles within the same day.

This appears however to be a limitation of the way Subtext currently renders aggregate views and ois not as easily fixed...

[)amien
# re: Subtext Origami Skin - Hotfix!
Gravatar Steven Harman
Aug 22, 2007
@Damien: I noticed that a while ago too, and yes - it is a problem with the way that Subtext aggregates posts. Right now it aggregates them first by entries per day, and then days per category/month/etc...

I'm hoping to change this when we overhaul the skinning architecture in the post Subtext 2.0 time frame.
# re: Subtext Origami Skin - Hotfix!
Gravatar Angry Hacker
Aug 22, 2007
Thanks for the fix. I've been out of the HTML game for 3 years (been doing winforms stuff), so I am a bit confused. Exactly how is <a> different from <a></a>? Why does this fix work?</a>
# re: Subtext Origami Skin - Hotfix!
Gravatar Steven Harman
Aug 22, 2007
@Angry: The reason that you can't use a self closing tag, such as <a ... /> is - well because that's how it was designed. :)

I know that's not probably not the answer you were looking for, but the truth is that the specifications for how an anchor tag works says that the tag must have an opening and closing tag. So the issue with using the self closing tag is that browsers that correctly implement the specification may behave erratically if you don't adhere to the spec.

This was the case with Firefox. It expects a closing tag but didn't find one - hence the rendered page was not as expected. Kind of like the old adage - You put crap in, you get crap out.

Hope this helps!
Comments have been closed on this topic.