Not too long ago a user sent us an email informing us that Subtext’s Origami skin didn’t have a #feedback tag, meaning it was missing a named anchor that would allow you to jump directly to the feedback portion of the page. I took a look and sure enough it didn’t.
This kind of bug is typically referred to as low hanging fruit - easy to spot, quick and easy to fix. So naturally I went ahead and added the named anchor tag, checked it into the Subtext SVN repository and called it fixed.
But it’s not fixed.
Today I was reading through some comments on my Life blog and noticed that the Gravatar image and comment title for the first comment of an individual post was not aligned correctly. A little inspection with Firebug and I found the issue.
Mea Culpa!
Apparently even low hanging fruit is sometimes too difficult for me to handle correctly. When I added the anchor tag I incorrectly made it a self-closing tag... which Firefox then misinterpreted and the mess pictured above resulted.
<div id="comments" class="section">
<a name="feedback" />
<h2 class="section-title">Your Comments.</h2>
Lucky for me the fix was a simple one. Where have I heard that before?
Like I was saying, the fix was pretty easy - I opened the skin’s Comments.ascx control and changed the anchor tag like so (notice the changes in bold):
<div id="comments" class="section">
<a name="feedback"></a>
<h2 class="section-title">Your Comments.</h2>
It’s magic, you know.
And just like that all is once again right with the World Subtext’s Origami skin. To all of the Subtexters out there, I would like to apologize for leading you astray... I’ll try my best to make sure it doesn’t happen again. Hopefully this blog post will get me back in your good graces. :)
Oh, and I should mention that this updated fix has been checked into SVN and will be in the forthcoming Subtext 1.9.6 release.
Again, Mea Culpa!
Technorati Tags:
subtext,
xhtml